CLN: Assorted #52248
Merged
CLN: Assorted #52248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
reviewed
Mar 28, 2023
| @@ -508,16 +508,16 @@ def _wrap_range_setop(self, other, res_i8): | |||
| result = type(self._data)._simple_new( | |||
| res_values, dtype=self.dtype, freq=new_freq | |||
| ) | |||
| return self._wrap_setop_result(other, result) | |||
| return cast("Self", self._wrap_setop_result(other, result)) | |||
There was a problem hiding this comment.
Looks like Index._wrap_setop_result should return Selfinstead of Index? Then you could avoid this cast?
There was a problem hiding this comment.
Can't bc it uses shallow_copy which doesn't return Self for RangeIndex
mroeschke
approved these changes
Mar 29, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.